[wp-trac] [WordPress Trac] #38738: Remove front page restrictions from new custom header functions
WordPress Trac
noreply at wordpress.org
Sun Nov 13 03:21:08 UTC 2016
#38738: Remove front page restrictions from new custom header functions
--------------------------------------+--------------------
Reporter: peterwilsoncc | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7
Component: Themes | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+--------------------
Changes (by peterwilsoncc):
* keywords: has-patch needs-unit-tests => has-patch has-unit-tests
Comment:
Replying to [comment:13 flixos90]:
> Why not go the clean way? :) I think since this feature is theme-
related, it should happen through theme support, especially since we
already have similar callbacks to add to `custom-header` support.
I like hooks because they're an established way of managing callback in a
forward compatible manner.
Given there are other callbacks in the feature, I'm happy to go with a
callback.
In [attachment:38738.3.diff]:
* reinstate the callback
* maintain the hook
* tests
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38738#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list