[wp-trac] [WordPress Trac] #38738: Remove front page restrictions from new custom header functions

[WordPress Trac]

#38738: Remove front page restrictions from new custom header functions
----------------------------------------+--------------------
 Reporter:  peterwilsoncc               |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  4.7
Component:  Themes                      |     Version:  trunk
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+--------------------

Comment (by flixos90):

 Replying to [comment:12 peterwilsoncc]:
 > * function always returns false if `custom-header, video` isn't
 supported by the theme

 Good catch, that totally makes sense to me.

 > While a callback is clean, a filter seems more WordPressy.

 Why not go the clean way? :) I think since this feature is theme-related,
 it should happen through theme support, especially since we already have
 similar callbacks to add to `custom-header` support. Maybe we can have
 both, the theme support, but still keep the filter you proposed (to filter
 the callback return value) in case a plugin needs to override for a
 special case.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38738#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform