[wp-trac] [WordPress Trac] #38678: Video Headers: Improve Basic Accessibility

[WordPress Trac]

#38678: Video Headers: Improve Basic Accessibility
------------------------------------+----------------------------
 Reporter:  davidakennedy           |       Owner:  joemcgill
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.7
Component:  Themes                  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  accessibility
------------------------------------+----------------------------

Comment (by bradyvercher):

 [attachment:38678.6.diff] refactors things a bit to make the handlers
 easier to understand. It:

 * Decouples the custom header class and handlers to remove the two-way
 communication between them.
 * Defines a base handler class that custom handlers should extend.
 * Updates the `CustomHeader.handlers` object to accept a handler instance.
 * Adds comments for the various classes and methods.
 * Updates the `sanitize_callback` for the `external_header_video` to
 `esc_url_raw`. This can be split into a separate ticket if necessary.

 I've tested this in multiple browsers and wrote a custom Vimeo handler and
 everything seems to be working well.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38678#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform