[wp-trac] [WordPress Trac] #38738: Remove front page restrictions from new custom header functions
WordPress Trac
noreply at wordpress.org
Fri Nov 11 09:42:47 UTC 2016
#38738: Remove front page restrictions from new custom header functions
---------------------------+--------------------
Reporter: peterwilsoncc | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7
Component: Themes | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
---------------------------+--------------------
Comment (by flixos90):
+1 for this.
I think we can leave the `is_front_page()` check in for a sane default,
but that return value should receive a filter so that theme developers who
explicitly need the video header in other areas can dig in to adjust it.
A solution that would be even cleaner is to allow an additional argument
when registering theme support for `custom-header`: Something like a
`has_video_cb` could be used, with the default value of `is_front_page`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38738#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list