[wp-trac] [WordPress Trac] #38738: Remove front page restrictions from new custom header functions

WordPress Trac noreply at wordpress.org
Thu Nov 10 22:41:38 UTC 2016


#38738: Remove front page restrictions from new custom header functions
---------------------------+--------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.7
Component:  Themes         |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:
---------------------------+--------------------
Changes (by peterwilsoncc):

 * keywords:   => needs-patch


Comment:

 @bradyvercher following up your request for feedback on the previous
 ticket.

 I am unsure either way, there are forward compatibility concerns with this
 change so a decision from the component maintainer/lead devs is required.

 My forward compatibility concern is that if this changes after a release,
 themes may be coded in such a way they can't be adapted. This can be
 mitigated but it's not elegant code.

 My inclination is to make this change and allow themes to limit to
 `is_front_page()` if they desire. With some encouragement they do so.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38738#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list