[wp-trac] [WordPress Trac] #38627: Twenty Seventeen: Custom Header Preview Doesn't Match in Customizer When Changed

WordPress Trac noreply at wordpress.org
Mon Nov 7 20:48:56 UTC 2016


#38627: Twenty Seventeen: Custom Header Preview Doesn't Match in Customizer When
Changed
------------------------------------+----------------------------
 Reporter:  davidakennedy           |       Owner:  davidakennedy
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.7
Component:  Bundled Theme           |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+----------------------------
Changes (by davidakennedy):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 This looks good, @bradyvercher! Thanks!

 One thing I noticed is that if you have a header image or video and remove
 it, you get this.

 [[Image(https://cldup.com/KrsIv_CEIU.png)]]

 That's because of the CSS on `:before` element. So my latest patch
 accounts for that. It's not perfect though because if you add an image or
 video, there's a flash of the blank space before the image or video pop
 in.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38627#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list