[wp-trac] [WordPress Trac] #38597: WP_Network::id is not a magic property

[WordPress Trac]

#38597: WP_Network::id is not a magic property
-----------------------------+-------------------------
 Reporter:  johnjamesjacoby  |       Owner:  jeremyfelt
     Type:  defect (bug)     |      Status:  reviewing
 Priority:  normal           |   Milestone:  4.7
Component:  General          |     Version:  4.6
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  multisite
-----------------------------+-------------------------
Changes (by flixos90):

 * keywords:  has-patch close => has-patch


Comment:

 Replying to [comment:5 johnjamesjacoby]:
 > It really shouldn't be both privately defined & publicly magic. Either
 we shouldn't privately define it, or we should publicly define it as what
 the magic method will always return.

 Well if PHP was type-safe... I'm not sure which solution to go for here. I
 tend to leave it publicly magic and change the internals. So I assume that
 would mean we'd need to store it in another way than the `$id` property?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38597#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform