[wp-trac] [WordPress Trac] #38597: WP_Network::id is not a magic property

WordPress Trac noreply at wordpress.org
Tue Nov 1 17:21:23 UTC 2016


#38597: WP_Network::id is not a magic property
-----------------------------+-------------------------
 Reporter:  johnjamesjacoby  |       Owner:  jeremyfelt
     Type:  defect (bug)     |      Status:  reviewing
 Priority:  normal           |   Milestone:  4.7
Component:  General          |     Version:  4.6
 Severity:  normal           |  Resolution:
 Keywords:  has-patch close  |     Focuses:  multisite
-----------------------------+-------------------------

Comment (by johnjamesjacoby):

 Replying to [comment:2 jeremyfelt]:
 > Hmm. On second thought. Does the `@property` tag help in this case
 because the property itself is private and access is magic?

 It really shouldn't be both privately defined & publicly magic. Either we
 shouldn't privately define it, or we should publicly define it as what the
 magic method will always return.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38597#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list