[wp-trac] [WordPress Trac] #34419: Update Pingback Processing Code
WordPress Trac
noreply at wordpress.org
Thu May 5 14:54:02 UTC 2016
#34419: Update Pingback Processing Code
-------------------------------------------------+-------------------------
Reporter: dshanske | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting
Component: Pings/Trackbacks | Review
Severity: minor | Version:
Keywords: needs-patch needs-refresh needs- | Resolution:
unit-tests | Focuses:
-------------------------------------------------+-------------------------
Comment (by dshanske):
Seems I may have overscoped here. Collectively, this was an attempt to
update the entire function, but I see the point of breaking it into
pieces.
1. I really have to learn how to write unit tests. It's a weakness of
mine, I admit. I may need help with that.
2. Will split it into a separate ticket.
3. This was basically an attempt at better early rejection to address
spammy pings, paired with HEAD request and the immediate rejection of
media content types(which is what we do in reverse when pinging a site).
The current logic looks for a URL in the content...but again...will break
it off into a separate ticket.
4. The average size of a webpage keeps increasing. But, point taken. May
be better to make that a filtered option to increase if I feel it is
needed, as opposed to hard-coding. And also, a separate ticket.
I guess I will be opening more tickets then I close again...
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34419#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list