[wp-trac] [WordPress Trac] #34419: Update Pingback Processing Code

[WordPress Trac]

#34419: Update Pingback Processing Code
-------------------------------------------------+-------------------------
 Reporter:  dshanske                             |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Pings/Trackbacks                     |  Review
 Severity:  minor                                |     Version:
 Keywords:  needs-patch needs-refresh needs-     |  Resolution:
  unit-tests                                     |     Focuses:
-------------------------------------------------+-------------------------
Changes (by rachelbaker):

 * keywords:  needs-patch => needs-patch needs-refresh needs-unit-tests


Comment:

 @dshanske There is so much going on in this patch, which makes
 understanding the implications difficult.  Some initial thoughts.

 1. I suggest using this ticket to address either the earlier processing of
 errors OR the sanitization, both of which will need unit tests.

 2. I would address removing the legacy conditional `url_to_postid` and
 `//$way` debugging line leftover from r30139 in a separate "bug" ticket
 (referencing the related commit) because that is a "good first bug" and
 straightforward.

 3. I would address adding the new `ping_source_verified` filter in a
 separate "enhancement" ticket.

 4. I see you are increasing the size of the response limit from 150 KB to
 1 MB, why is that needed?  The current limit was kept low to prevent
 denial of service attacks (see #4137).  I would caution against increasing
 the number.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34419#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform