[wp-trac] [WordPress Trac] #35379: update_network_option changes stored option value if sanitize_option detects error

[WordPress Trac]

#35379: update_network_option changes stored option value if sanitize_option
detects error
-------------------------------------------------+-------------------------
 Reporter:  thomaswm                             |       Owner:  jeremyfelt
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.6
Component:  Options, Meta APIs                   |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:  multisite
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by jeremyfelt):

 * keywords:  has-patch has-unit-tests dev-feedback needs-testing => has-
     patch has-unit-tests needs-testing


Comment:

 I gave another read through `sanitize_option()` and still find myself
 falling in favor of a new `sanitize_network_option()`. We would still need
 to add the old filter, but we could drop all of the site specific option
 switching and just focus on the network. This would also eliminate the
 need to pass both `$context` and `$context_id`.

 Thoughts?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35379#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform