[wp-trac] [WordPress Trac] #36255: Custom Logo: Crop UI

WordPress Trac noreply at wordpress.org
Fri Mar 18 04:35:27 UTC 2016

#36255: Custom Logo: Crop UI
 Reporter:  mor10         |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.5
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui
Changes (by westonruter):

 * keywords:  has-patch commit => has-patch


 In some additional testing I found a key problem with [36255.0.diff]
 specifically in regards to Twenty Sixteen. It defines its logo image size

         add_image_size( 'twentysixteen-logo', 1200, 175 );

 Notice the very wide width but the absence of the `$crop` argument. In
 other words, this image size is indicating the ''maximum'' width and
 ''maximum'' height that that the image can be. Nevertheless, in the patch
 it would present the fixed crop at that ratio, resulting in a very wide
 image crop, which likely would not be desired. I've improved this in
 [attachment:36255.1.diff] by taking into account the `$crop` arg, opting
 to not use a cropped image control if this is not defined.

Ticket URL: <https://core.trac.wordpress.org/ticket/36255#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list