[wp-trac] [WordPress Trac] #35947: Customizer panel fails to fully expand leaving extra margin
WordPress Trac
noreply at wordpress.org
Sat Mar 5 16:29:12 UTC 2016
#35947: Customizer panel fails to fully expand leaving extra margin
--------------------------+---------------------------
Reporter: tronoxas | Owner: ryankienstra
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.5
Component: Customize | Version: 4.4.2
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
--------------------------+---------------------------
Comment (by delawski):
'''Different approach proposal'''
I have pushed my proposal for the fix to the issue. Instead of removing
{{{_recalculateTopMargin()}}} which is risky in current sliding panels
implementation and may cause new issues, I have delayed focus event on
back button.
While working on #34391, I've noticed that focusing on element during CSS
transition may cause unexpected results, very similar to the one
presented. In case of #34391 I have implemented full solution taking
advantage of {{{transitionEnd}}} event listening. In case of this ticket,
I have used simpler solution - {{{focus()}}} is delayed by 180 ms which is
the time needed for the transition to end.
I've tested the fix on Chrome/OS X, Firefox/OS X, Firefox/Windows 8.1,
Firefox/Windows 7, IE11/Windows 7 (Twenty Sixteen in each case).
''As a side note: I was able to reproduce the original issue only in
Firefox.''
----
'''Please, use
[https://core.trac.wordpress.org/attachment/ticket/35947/35947_clean.patch
35947_clean.patch] patch as it doesn't contain initial commits and
reverts.'''
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35947#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list