[wp-trac] [WordPress Trac] #37116: Fix travis builds for previous branches

[WordPress Trac]

#37116: Fix travis builds for previous branches
------------------------------+------------------
 Reporter:  jorbin            |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.6
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+------------------

Comment (by netweb):

 Both the 4.4 and 4.5 branch builds on Travis CI error with:
 {{{(node) warning: Recursive process.nextTick detected. This will break in
 the next version of node. Please use setImmediate for recursive
 deferral.}}}

 This appears to be a conflict between the NodeJS modules dependancy tree,
 which as always is crazy insane.

 Approximately a dozen NPM modules require NodeJS >= 0.12.x

 For example:
 * The `grunt-postcss` update from `0.7.0` to `0.8.0` was reverted in
 r36980 because NodeJS 0.10.x support was dropped
 * `grunt-postcss` has an NPM dependancy of `"postcss": "^5.0.0"`
 * NodeJS `0.10.x` support in `postcss` was dropped in version `5.0.6`
 * This is semantic version bug in `grunt-postcss` and it should not have
 been released in this manner, though that horse has bolted now and very
 little can be done in that NPM module to rectify or reinstate NodeJS
 `0.10.x` compatibility, I created an [https://github.com/nDmitry/grunt-
 postcss/issues/96 issue] to document this for the maintainers so hopefully
 this can be avoided in the future.

 Hence, our Travis CI builds require a minimum of NodeJS `0.12.x` otherwise
 there be explosions!

 Here's some test PR's and all 4 pass
 * NodeJS 0.12.x branch on WP 4.4 branch: https://travis-
 ci.org/aaronjorbin/develop.wordpress/builds/139091078
 * NodeJS 0.12.x branch on WP 4.5 branch: https://travis-
 ci.org/aaronjorbin/develop.wordpress/builds/139091042
 * NodeJS 4.x branch on WP 4.4 branch: https://travis-
 ci.org/aaronjorbin/develop.wordpress/builds/139089182
 * NodeJS 4.x branch on WP 4.5 branch: https://travis-
 ci.org/aaronjorbin/develop.wordpress/builds/139088613

 @jorbin The resolution to resolve this ticket is to bump NodeJS to 0.12.x
 or 4.x, which is what ticket #35105 is all about.

 My suggestion included in [attachment:37116-nodejs-4x-lts.diff] is to bump
 to 4.x LTS for all the branches (4.4, 4.5, and /trunk). This would save us
 from having to redo it again in a couple of months for the 4.4/4.5
 branches when LTS support ends for NodeJS 0.12.x.

 In using NodeJS 4.x LTS support here for all the branches I can't forsee
 any issues on the Travis CI side of things.

 On the `https://core.svn.wordpress.org/` side of things having NodeJS 4.x
 LTS installed would be beneficial in that it is only one single instance
 of NodeJS required on the "build" server rather than having to maintain
 multiple versions using NVM.

 Slack discussion on bumping NodeJS on the build server:
 [https://wordpress.slack.com/archives/meta/p1457914147000023
 wordpress.slack.com/archives/meta/p1457914147000023]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37116#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform