[wp-trac] [WordPress Trac] #36742: Comments List Table: Comment date doesn't get linked on status change via Ajax
WordPress Trac
noreply at wordpress.org
Thu Jun 16 20:13:55 UTC 2016
#36742: Comments List Table: Comment date doesn't get linked on status change via
Ajax
--------------------------+--------------------------
Reporter: ocean90 | Owner: rachelbaker
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.6
Component: Comments | Version: 4.5
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+--------------------------
Comment (by adamsilverstein):
@imath thanks for your patch, this works well in my testing.
In [attachment:36742.2.patch] I did a tiny bit of cleanup: adding a
training comma in the array structure as per WP coding standards, adding
periods at the end of inline comment statements and also I switched from
.html() to .text() where possible because I consider .html() as a possible
security vector because it evaluates passed scripts. For this reason I try
to use .text whenever possible as a matter of course (even though here I
don't think there was a risk).
I'm a little surprised and disgruntled that we have to add the JS to wp-
lists.js, but this does appear to be the appropriate spot . Nice work!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36742#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list