[wp-trac] [WordPress Trac] #36675: WP_MS_Sites_List_Table should use WP_Site_Query

[WordPress Trac]

#36675: WP_MS_Sites_List_Table should use WP_Site_Query
--------------------------------------+-------------------------
 Reporter:  spacedmonkey              |       Owner:  jeremyfelt
     Type:  task (blessed)            |      Status:  accepted
 Priority:  normal                    |   Milestone:  4.6
Component:  Networks and Sites        |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+-------------------------
Changes (by jeremyfelt):

 * keywords:  has-patch needs-unit-tests => has-patch has-unit-tests
 * owner:   => jeremyfelt
 * status:  reopened => accepted


Comment:

 Replying to [comment:19 jeremyfelt]:
 > Existing tests have been updated to show new results. I did not add
 tests for wildcards in the middle of a search term, though that appears to
 be fine.

 [attachment:36675.4.diff] includes the latest patch for #35791, which adds
 support for search columns in `WP_Site_Query` and tests for wildcard
 searching.

 > I did not add the subdomain check back, though I think that should still
 happen.

 This is back. If subdomain, then results are ordered by domain and both
 domain and path are searched. If subdirectory, results are ordered by path
 and only path is searched.

 I believe the current patch fixes:

 * #33185, which is a general ticket for how site search barely worked
 because only portions of the domain or path were being searched against.
 * #24833, which describes search not working for a subdomain configuration
 in which domains have been changed arbitrarily.
 * #21837, which is similar to both of the above tickets but deals
 specifically with domain search not working in which the primary site is
 itself a subdomain.
 * #26580 isn't necessarily fixed, but the use of `WP_Site_Query` makes it
 much easier to add a filter similar to `users_list_table_query_args`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36675#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform