[wp-trac] [WordPress Trac] #36675: WP_MS_Sites_List_Table should use WP_Site_Query

[WordPress Trac]

#36675: WP_MS_Sites_List_Table should use WP_Site_Query
----------------------------------------+------------------------
 Reporter:  spacedmonkey                |       Owner:
     Type:  task (blessed)              |      Status:  reopened
 Priority:  normal                      |   Milestone:  4.6
Component:  Networks and Sites          |     Version:  trunk
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  multisite
----------------------------------------+------------------------

Comment (by jeremyfelt):

 Replying to [comment:16 ocean90]:
 > [attachment:36675.2.diff] has an issue when a persistent object cache is
 in use: On first load all sites are correctly fetched and a pagination is
 visible. On second load only the first page is visible, no pagination.

 [attachment:36675.3.diff] uses the same approach as the comments list
 table for this. The first query is handled through `get_sites()` and then
 a query to get the total count is handled through another `get_sites()`
 call.

 Existing tests have been updated to show new results. I did not add tests
 for wildcards in the middle of a search term, though that appears to be
 fine.

 I did not add the subdomain check back, though I think that should still
 happen.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36675#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform