[wp-trac] [WordPress Trac] #36749: Customizer wont load: issue with site-icon control
WordPress Trac
noreply at wordpress.org
Sat Jun 4 18:32:00 UTC 2016
#36749: Customizer wont load: issue with site-icon control
--------------------------+-------------------------
Reporter: raxcido | Owner: swissspidy
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.5.3
Component: Customize | Version: 4.5
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript
--------------------------+-------------------------
Comment (by swissspidy):
I assume the whole issue came to light because of the bug reported in
#36534, which has caused many uploaded images not having intermediate
sizes.
#37030 mentions other cases where the exact same fix as in [37456] was
suggested because that's used elsewhere in core as well, like
`WP_Customize_Media_Control` and `wp-includes/media-template.php`. If
we're going to implement something like [attachment:36749.2.diff] or
[attachment:36749.4.diff], we should have a look at those files as well in
a new ticket.
Since both patches lead to the same result, I tend to implement
[attachment:36749.2.diff] as it results in a cleaner diff.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36749#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list