[wp-trac] [WordPress Trac] #37351: Already intalled plugin shows with "Install Now" button on plugin-install.php page (was: Shiny Updates: Already intalled plugin shows with "Install Now" button on plugin-install.php page)

[WordPress Trac]

#37351: Already intalled plugin shows with "Install Now" button on plugin-
install.php page
--------------------------+------------------------------
 Reporter:  mapk          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Plugins       |     Version:  3.0
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  ui
--------------------------+------------------------------
Changes (by swissspidy):

 * version:  trunk => 3.0


Comment:

 I assume the already installed plugin is `wp-content/plugins/hello.php`,
 which gets shipped with every WordPress site by default.

 On the `plugin-install.php` screen, Hello Dolly is displayed as not being
 installed because `install_plugin_install_status()` checks if the `wp-
 content/plugins/hello-dolly/` directory exists. Obviously it doesn't,
 because it's just a PHP file. Therefore you're able to install the plugin
 from WordPress.org.

 Technically those are separate plugins that happen to have the same name.
 It's like having a GitHub checkout from WooCommerce inside `wp-
 content/plugins/woocommerce-master`. You can still download it from
 WordPress.org

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37351#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform