[wp-trac] [WordPress Trac] #27404: Widget Customizer: Allow adding inactive widgets to widget areas
WordPress Trac
noreply at wordpress.org
Tue Feb 23 15:05:53 UTC 2016
#27404: Widget Customizer: Allow adding inactive widgets to widget areas
-------------------------------------+-----------------------------
Reporter: westonruter | Owner:
Type: feature request | Status: assigned
Priority: normal | Milestone: Future Release
Component: Widgets | Version: 3.9
Severity: normal | Resolution:
Keywords: needs-patch ux-feedback | Focuses: ui, javascript
-------------------------------------+-----------------------------
Comment (by rramo012):
Thanks for reviewing our submission. I'm the InMotion Hosting dev handling
this ticket.
Replying to [comment:33 westonruter]:
> FYI: the minified files should not be modified.
We submitted the build results of the develop.svn.wordpress.org repo.
We'll create a patch with only the modified files.
> In terms of Customizer architecture, I wonder if instead of introducing
a new setting `widgets_deleted`, whether it would be better to instead
just rely on the existing `widget_{id_base}[{number}]` settings.
That was my initial approach. The reasoning behind going with a new
customizer setting was that setting the widget instance to false was
causing failures in sanitation
(WP_Customize_Widgets->sanitize_widget_instance()). I didn't want to
unintentionally make the existing sanitation for widget instances
venerable. Instead I treated it similarly to a sidebars and used its
sanitation. Additionally I feel the intention is more clear when a widget
is added to a deletion array.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27404#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list