[wp-trac] [WordPress Trac] #27404: Widget Customizer: Allow adding inactive widgets to widget areas
WordPress Trac
noreply at wordpress.org
Mon Feb 22 18:46:56 UTC 2016
#27404: Widget Customizer: Allow adding inactive widgets to widget areas
-------------------------------------+-----------------------------
Reporter: westonruter | Owner:
Type: feature request | Status: assigned
Priority: normal | Milestone: Future Release
Component: Widgets | Version: 3.9
Severity: normal | Resolution:
Keywords: needs-patch ux-feedback | Focuses: ui, javascript
-------------------------------------+-----------------------------
Comment (by westonruter):
Replying to [comment:32 todd-inmotion]:
> @westonruter - Just wanted to be sure you saw the patch. Let me know if
you need anything else or if you want a login to one of our WP installs to
see it in place.
FYI: the minified files should not be modified. These will be
automatically generated during the build step. In other words, write the
patch against the _develop_ (src) repo at develop.svn.wordpress.org as
opposed to the _build_ at core.svn.wordpress.org; see
https://make.wordpress.org/core/2013/08/06/a-new-frontier-for-core-
development/ for more info.
In terms of Customizer architecture, I wonder if instead of introducing a
new setting `widgets_deleted`, whether it would be better to instead just
rely on the existing `widget_{id_base}[{number}]` settings, but to treat
any that have values of `false` as an indication that they should be
deleted. This is in fact how nav menu items deletions are handled. For
reference, see:
PHP: https://core.trac.wordpress.org/browser/tags/4.4.2/src/wp-
includes/customize/class-wp-customize-nav-menu-item-
setting.php?marks=682,689-703#L675
JS: https://core.trac.wordpress.org/browser/tags/4.4.2/src/wp-admin/js
/customize-nav-menus.js?marks=1194-1228#L1194
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27404#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list