[wp-trac] [WordPress Trac] #39387: Responsive Images Broken When Full Size <= 300 px

[WordPress Trac]

#39387: Responsive Images Broken When Full Size <= 300 px
--------------------------+------------------------
 Reporter:  miqrogroove   |       Owner:  joemcgill
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  4.8
Component:  Media         |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------
Changes (by joemcgill):

 * owner:   => joemcgill
 * status:  new => reviewing


Comment:

 Thanks @miqrogroove.

 Briefly, I wanted to note that what you're experiencing is currently the
 intended behavior based on #34528. However, I understand how this could be
 less than ideal when the GIF is not animated and including the full size
 in the `srcset` would be desired.

 I don't think we actually need a new filter here, because you should be
 able to accomplish what you are after with the `wp_calculate_image_srcset`
 filter by adding the full size to the `srcset` after it has been
 calculated. You can even pass the `$image_meta` directly to your filter to
 check the MIME type and add the information for the full size image.

 A potential fix would be finding a better way to determine when a GIF is
 animated. But we would need to do so without adding unnecessary processing
 time to `wp_calculate_image_srcset()` since it's run as a display filter
 on the front end. If we aren't able to do so, I'm afraid this will
 probably be a ''wontfix''.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39387#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform