[wp-trac] [WordPress Trac] #39387: Responsive Images Broken When Full Size <= 300 px

WordPress Trac noreply at wordpress.org
Sun Dec 25 15:30:51 UTC 2016


#39387: Responsive Images Broken When Full Size <= 300 px
--------------------------+------------------
 Reporter:  miqrogroove   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.8
Component:  Media         |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------
Changes (by miqrogroove):

 * keywords:   => has-patch


Comment:

 Replying to [comment:11 markoheijnen]:
 > Basically there are two issues. We need to look how to deal better when
 imagick breaks.

 A different ticket perhaps?  I could not find a root cause of the crashes,
 other than pointing to the Imagick library itself.

 > A filter for response images can be introduced but it would mean when
 the original is included, that other images disappear. Unless the editor
 did create images with animation saved but till now we don't have that
 (yet).

 Patch for new filter attached.  Yes, it will "flatten" animated GIFs.  I
 have no animated GIFs on my website whatsoever, which means my image
 quality suffers noticeably on HiDPI devices by default.  Using this
 filter, I can inform core that my preference is to always have the srcset.

 The only alternative I could think of was to use the
 'wp_calculate_image_srcset_meta' filter to erase the mime-type value,
 which does not seem like a future-proof strategy.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39387#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list