[wp-trac] [WordPress Trac] #37217: get_network_by_path should use WP_Network_Query

[WordPress Trac]

#37217: get_network_by_path should use WP_Network_Query
--------------------------------------+------------------------
 Reporter:  spacedmonkey              |       Owner:  flixos90
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  4.8
Component:  Networks and Sites        |     Version:  4.6
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+------------------------
Changes (by jeremyfelt):

 * milestone:  Future Release => 4.8


Comment:

 The changes to `WP_Network::get_by_path` look good, I think we can move
 forward with this.

 I made a few changes in [attachment:37217.4.diff]:

 * Only run the no path tests when an external object cache is available.
 Otherwise I was getting a bunch of test errors locally with the tests in
 `pluggable.php`. I think we're safe to only focus on object cache setups
 here as that is the only time this code will fire.
 * Remove an old `@todo` note that doesn't really make sense any more.
 * Add test cases for how we deal with the lookup for a network with
 multiple paths.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37217#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform