[wp-trac] [WordPress Trac] #37217: get_network_by_path should use WP_Network_Query

[WordPress Trac]

#37217: get_network_by_path should use WP_Network_Query
--------------------------------------+-----------------------------
 Reporter:  spacedmonkey              |       Owner:  flixos90
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  Future Release
Component:  Networks and Sites        |     Version:  4.6
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+-----------------------------
Changes (by flixos90):

 * keywords:  has-patch needs-unit-tests => has-patch has-unit-tests


Comment:

 In [attachment:37217.3.diff] I added an additional unit test with data
 provider for when using `get_network_by_path()` with the `$using_paths`
 flag set to false. I made sure the both tests pass with the existing as
 well as the new code using `WP_Network_Query`.
 The new test actually uncovered an issue with the previous patch where I
 accidentally had `ASC` in line 365 of the `WP_Network` class. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37217#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform