[wp-trac] [WordPress Trac] #39272: Twenty Seventeen: Incorrect $content_width

[WordPress Trac]

#39272: Twenty Seventeen: Incorrect $content_width
-------------------------------------------------+-------------------------
 Reporter:  celloexpressions                     |       Owner:
     Type:  defect (bug)                         |  laurelfulford
 Priority:  normal                               |      Status:  assigned
Component:  Bundled Theme                        |   Milestone:  4.7.1
 Severity:  major                                |     Version:  4.7
 Keywords:  has-patch needs-testing dev-         |  Resolution:
  feedback                                       |     Focuses:
-------------------------------------------------+-------------------------
Changes (by davidakennedy):

 * keywords:  has-patch needs-testing => has-patch needs-testing dev-
               feedback


Comment:

 Thanks for the work here @laurelfulford and @sstoqnov!

 I'd definitely prefer keeping all the content width changes in one
 function to make it easier to understand and work with for developers.

 Some tiny feedback for [attachment:39272.2.patch] @sstoqnov, there are a
 few comments without spaces after the `//`. Also, can we end those in a
 full stop (period)? That's per coding standards we're trying to improve in
 #39152. :) Otherwise, it's looking good.

 In testing, this worked well. I can verify that the `after_setup_theme`
 hook isn't sufficient here. From reading the source code, it does seem
 like the `wp` hook would be best to use. But I'd like to get a second
 opinion to be sure. @obenland Is `wp` the best hook to use here since the
 code needs to use some conditional tags and theme functions?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39272#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform