[wp-trac] [WordPress Trac] #39272: Twenty Seventeen: Incorrect $content_width
WordPress Trac
noreply at wordpress.org
Thu Dec 15 07:54:59 UTC 2016
#39272: Twenty Seventeen: Incorrect $content_width
-------------------------------------+----------------------------
Reporter: celloexpressions | Owner: laurelfulford
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.7.1
Component: Bundled Theme | Version: 4.7
Severity: major | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+----------------------------
Changes (by sstoqnov):
* keywords: has-patch => has-patch needs-testing
Comment:
Thank for the comment @davidakennedy.
@celloexpressions I agree with you that will be better to have everything
in functions.php, but after spending some time I reallized that using
`after_setup_theme` action doesn't allow us to use conditional tags. The
previous check that I have removed also doesn't work, because
`twentyseventeen_is_frontpage` always rerun false.
We can use `wp` hook, so that everything we need will be loaded.
In 39272.2.patch I replaced `after_setup_theme` with `wp` action and
combine the good work from @laurelfulford in
`twentyseventeen_content_width` function.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39272#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list