[wp-trac] [WordPress Trac] #39138: wordpress 4.7 default theme does not get installed when upgrading

[WordPress Trac]

#39138: wordpress 4.7 default theme does not get installed when upgrading
-----------------------------+-----------------------
 Reporter:  christianebuddy  |       Owner:
     Type:  defect (bug)     |      Status:  reopened
 Priority:  normal           |   Milestone:  4.7.1
Component:  Bundled Theme    |     Version:  4.7
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+-----------------------

Comment (by dd32):

 Replying to [comment:5 Clorith]:
 > Hmm, I thought the change was only for development builds to allow
 testing of new default themes.

 The early ticket comments hints towards that, but we went all out and did
 it for all.

 > [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes
 /class-wp-filesystem-direct.php?rev=39064#L329 DirectFS] and
 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes
 /class-wp-filesystem-ssh2.php?rev=39064#L448 SSH2] does a check against
 `file_exists( $file )`, where a `true` value should end processing, and a
 `false` one should keep going (so in these two cases bundles won't be
 installed if they don't already exist)
 >
 > [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes
 /class-wp-filesystem-ftpext.php?rev=39064#L337 FTPExt] and
 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes
 /class-wp-filesystem-ftpsockets.php?rev=39064#L346 FTPSocket] appear to be
 the opposite and return `false` to end processing, and `true` to keep
 going (the behavior we are expecting in `update-core.php` right now).

 That doesn't sound right.. It's checking to see if the files exist in the
 source (ie. the unziped files). The logic in all of the transports looks
 the same to me though, Direct/SSH `file_exists`, FTP: `if directory, or
 file exists in directory listing`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39138#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform