[wp-trac] [WordPress Trac] #39138: wordpress 4.7 default theme does not get installed when upgrading

[WordPress Trac]

#39138: wordpress 4.7 default theme does not get installed when upgrading
-----------------------------+-----------------------
 Reporter:  christianebuddy  |       Owner:
     Type:  defect (bug)     |      Status:  reopened
 Priority:  normal           |   Milestone:  4.7.1
Component:  Bundled Theme    |     Version:  4.7
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+-----------------------

Comment (by Clorith):

 Hmm, I thought the change was only for development builds to allow testing
 of new default themes.

 I think I see why this is though.

 The check at https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/update-core.php?rev=39064&marks=1047#L1047 short-circuit
 the install of new bundles if `false`, so we have some scenarios to look
 at depending on what is handling the `$wp_filesystem->exists()` check:

 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes
 /class-wp-filesystem-direct.php?rev=39064#L329 DirectFS] and
 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes
 /class-wp-filesystem-ssh2.php?rev=39064#L448 SSH2] does a check against
 `file_exists( $file )`, where a `true` value should end processing, and a
 `false` one should keep going (so in these two cases bundles won't be
 installed if they don't already exist)

 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes
 /class-wp-filesystem-ftpext.php?rev=39064#L337 FTPExt] and
 [https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes
 /class-wp-filesystem-ftpsockets.php?rev=39064#L346 FTPSocket] appear to be
 the opposite and return `false` to end processing, and `true` to keep
 going (the behavior we are expecting in `update-core.php` right now).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39138#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform