[wp-trac] [WordPress Trac] #38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.

[WordPress Trac]

#38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.
------------------------------+------------------------
 Reporter:  joemcgill         |       Owner:  joemcgill
     Type:  defect (bug)      |      Status:  accepted
 Priority:  normal            |   Milestone:  4.7
Component:  Bundled Theme     |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+------------------------

Comment (by laurelfulford):

 Thanks @joemcgill!

 > Looks like 38995.2.patch​ missed changing the classname of the media
 container div to .custom-header-media.

 Oh weird! It looks like it's
 [https://core.trac.wordpress.org/attachment/ticket/38995/38995.2.patch in
 the patch]. I've been getting a 'Hunk failed' error from that file on the
 other patches - I wonder if that's why it didn't carry over?

 Thinks look good overall. I found an issue while testing that's unrelated
 to these changes - the header fully disappears for a few seconds in the
 preview if you do the following:

 1. Remove header image and header video.
 2. Save and publish.
 3. Refresh the customizer.
 4. Add a header image.

 The whole header disappears in the preview, and then appears with the
 image.

 It looks to be related to the fix from #38927. The good news is this patch
 includes some JavaScript that fixes the same thing, outlined in
 [https://core.trac.wordpress.org/ticket/38995#comment:8 item four here].
 The check for `has_custom_header()` in header-image.php is no longer
 needed, and removing it fixes the disappearing header.

 I added this in [attachment:38995.4.patch]. When testing this, can you
 please check that the `custom-header-media` class made it over intact?
 Thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38995#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform