[wp-trac] [WordPress Trac] #38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.

WordPress Trac noreply at wordpress.org
Thu Dec 1 20:26:44 UTC 2016


#38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.
------------------------------+------------------------
 Reporter:  joemcgill         |       Owner:  joemcgill
     Type:  defect (bug)      |      Status:  accepted
 Priority:  normal            |   Milestone:  4.7
Component:  Bundled Theme     |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+------------------------
Changes (by joemcgill):

 * keywords:  has-patch needs-testing => has-patch commit


Comment:

 @laurelfulford Thanks for these changes. I only noticed two small things
 which I've addressed in [attachment:38995.3.patch].

 a) I removed the logic I had added in customize-previews.js that adds the
 `.has-video-header` class to match what you had originally done in
 [attachment:38995.patch].
 b) Looks like [attachment:38995.2.patch] missed changing the classname of
 the media container div to `.custom-header-media`.

 Let me know if you have any other feedback, otherwise I think this is good
 to commit.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38995#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list