[wp-trac] [WordPress Trac] #34923: Allow users to more seamlessly create page-based nav menus during customization

[WordPress Trac]

#34923: Allow users to more seamlessly create page-based nav menus during
customization
-------------------------------------+-------------------------------------
 Reporter:  westonruter              |       Owner:  westonruter
     Type:  enhancement              |      Status:  accepted
 Priority:  high                     |   Milestone:  4.7
Component:  Customize                |     Version:  4.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch ux-feedback    |     Focuses:  ui, accessibility,
  needs-testing has-screenshots      |  javascript
  needs-unit-tests                   |
-------------------------------------+-------------------------------------
Changes (by westonruter):

 * keywords:  has-patch ux-feedback needs-testing has-screenshots => has-
     patch ux-feedback needs-testing has-screenshots needs-unit-tests


Comment:

 In [attachment:34923.6.diff]:

 * [https://github.com/xwp/wordpress-develop/pull/152/commits/6a51eca
 6a51eca] Fix JSHint issues
 * [https://github.com/xwp/wordpress-develop/pull/152/commits/120ac63
 120ac63] Fix JSCS issues
 * [https://github.com/xwp/wordpress-develop/pull/152/commits/93eeb23
 93eeb23] Fix PHPCS issues
 * [https://github.com/xwp/wordpress-develop/pull/152/commits/eeef76d
 eeef76d] Add sanitization for nav_menus_created_posts setting
 * [https://github.com/xwp/wordpress-develop/pull/152/commits/1eaa45b
 1eaa45b] Ensure that nav_menus_created_posts is set with clone since
 arrays passed by reference
 * [https://github.com/xwp/wordpress-develop/pull/152/commits/c81e576
 c81e576] Eliminate edit post links in notifications per discussion
 * [https://github.com/xwp/wordpress-develop/pull/152/commits/ee187ad
 ee187ad]  Move auto-draft post insertion into nav_menus component
 * [https://github.com/xwp/wordpress-develop/pull/152/commits/5bb985e
 5bb985e] Use flexbox to lay out new-content-item

 Todo:

 * Insert latest version of `ajax_insert_auto_draft_post` from Customize
 Posts: https://github.com/xwp/wp-customize-
 posts/blob/6c52c8a8dc3dca21dc6984b7a5ae274b8e079c89/php/class-wp-
 customize-posts.php#L1064-L1131
 * Integrate latest version of `insert_auto_draft_post` from Customize
 Posts: https://github.com/xwp/wp-customize-
 posts/blob/6c52c8a8dc3dca21dc6984b7a5ae274b8e079c89/php/class-wp-
 customize-posts.php#L930-L968
 * Add unit tests (tests can likely be copied from Customize Posts, which
 has coverage for these functions).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34923#comment:69>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform