[wp-trac] [WordPress Trac] #37416: In WP_Comment_Query::fill_descendants() compute the size beforehand and not on each iteration

[WordPress Trac]

#37416: In WP_Comment_Query::fill_descendants() compute the size beforehand and not
on each iteration
-------------------------------------------------+-------------------------
 Reporter:  ocean90                              |       Owner:
     Type:  defect (bug)                         |  wonderboymusic
 Priority:  low                                  |      Status:  closed
Component:  Comments                             |   Milestone:  Future
 Severity:  normal                               |  Release
 Keywords:  good-first-bug has-patch needs-      |     Version:  4.4
  testing                                        |  Resolution:  fixed
                                                 |     Focuses:
                                                 |  performance
-------------------------------------------------+-------------------------

Comment (by wonderboymusic):

 In [changeset:"38298"]:
 {{{
 #!CommitTicketReference repository="" revision="38298"
 Comments: in `WP_Comment_Query::fill_descendants()`, `continue` if there
 is an empty array in the loop.

 See #37416, [38297].
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37416#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform