[wp-trac] [WordPress Trac] #37416: In WP_Comment_Query::fill_descendants() compute the size beforehand and not on each iteration

[WordPress Trac]

#37416: In WP_Comment_Query::fill_descendants() compute the size beforehand and not
on each iteration
-------------------------------------------------+-------------------------
 Reporter:  ocean90                              |       Owner:
     Type:  defect (bug)                         |  wonderboymusic
 Priority:  low                                  |      Status:  closed
Component:  Comments                             |   Milestone:  Future
 Severity:  normal                               |  Release
 Keywords:  good-first-bug has-patch needs-      |     Version:  4.4
  testing                                        |  Resolution:  fixed
                                                 |     Focuses:
                                                 |  performance
-------------------------------------------------+-------------------------
Changes (by wonderboymusic):

 * owner:   => wonderboymusic
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38297"]:
 {{{
 #!CommitTicketReference repository="" revision="38297"
 Comments: in `WP_Comment_Query::fill_descendants()`, compute `count()` in
 the first `for` expression so that it does not run on each iteration.

 Props vishalkakadiya, deremohan.
 Fixes #37416.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37416#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform