[wp-trac] [WordPress Trac] #35791: WP_Site_Query class

[WordPress Trac]

#35791: WP_Site_Query class
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:
     Type:  task (blessed)                       |  DrewAPicture
 Priority:  normal                               |      Status:  reviewing
Component:  Networks and Sites                   |   Milestone:  4.6
 Severity:  normal                               |     Version:  4.4
 Keywords:  has-patch needs-testing needs-unit-  |  Resolution:
  tests                                          |     Focuses:  multisite
-------------------------------------------------+-------------------------

Comment (by DrewAPicture):

 @spacedmonkey [attachment:35791-class.patch] fixes a few docs syntax
 issues and fixes alignment on the hash notation in `__construct()`.

 ''Note: If you name your patches the same every time, Trac will increment
 the number for you. Uploading 35791-class.patch again will increment it to
 35791-class.2.patch, and so on ;-)''

 Here are some notes not covered in [attachment:35791-class.patch]:

 * If the `$ID` argument (`__construct()`) is currently unused, perhaps we
 shouldn't include it in arguments for the new class?
 * What "back-compat" are we supporting exactly in adding a `__call()`
 magic method? It was probably added based on similar classes, but we
 should decide now if calling protected and private methods should be
 supported in this ''new'' class ;)
 * Missing hook docs for `parse_site_query` action
 * Odd to have a `get_sites()` method that relies entirely on query vars
 * We should probably include 'join' in the `$sql_clauses` array even
 though it's not really in use by core

 Next up: [attachment:35791i.1.patch]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35791#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform