[wp-trac] [WordPress Trac] #32941: Customizer changes to input field values after clicking Save not recorded
WordPress Trac
noreply at wordpress.org
Fri Apr 22 17:46:41 UTC 2016
#32941: Customizer changes to input field values after clicking Save not recorded
--------------------------+-------------------------
Reporter: mb5324897 | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.6
Component: Customize | Version: 4.2.2
Severity: normal | Resolution:
Keywords: needs-patch | Focuses: javascript
--------------------------+-------------------------
Comment (by chandrapatel):
Hi @westonruter,
Okay. Now I understood why we can't keep the Save button enabled. Thanks.
I have added `fieldset` element as child of form and then applied disabled
attribute to this element which disabled all controls. I have also check
whether `disabled` state enabled or not for `fieldset`. If it enabled then
only I remove `disabled` state from `fieldset`.
I have uploaded new patch `32941.1.patch`.
But I noticed some bad behavior for color picker and drag/drop widgets. To
see this behavior add `sleep(30)` code at line #1032 in `save()` method in
`wp-includes/class-wp-customize-manager.php`. Then use and check behavior
of color picker and drag/drop widgets.
Another alternative solution is, We disable only `Save & Publish` button.
User can change settings during ajax request in-progress and we set flag
if any settings changed and once ajax request complete then we check if
flag set then we enable `Save & Publish`. So user can save their settings
again. If flag not set then `save` button in disabled mode.
Please let me know your suggestion.
Regards
--
Ticket URL: <https://core.trac.wordpress.org/ticket/32941#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list