[wp-trac] [WordPress Trac] #32941: Customizer changes to input field values after clicking Save not recorded

WordPress Trac noreply at wordpress.org
Fri Apr 22 04:06:52 UTC 2016


#32941: Customizer changes to input field values after clicking Save not recorded
--------------------------+-------------------------
 Reporter:  mb5324897     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.6
Component:  Customize     |     Version:  4.2.2
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  javascript
--------------------------+-------------------------

Comment (by westonruter):

 @chandrapatel A reason for why we can't keep the Save button enabled
 because if the user keeps trying to save new changes while other changes
 are being saved, there could be a race condition where one save request
 could finish in an unexpected order.

 I'm concerned that your [attachment:32941.patch] would have unexpected
 side effect of re-enabling inputs that were previously set to be disabled
 after a save completes. One possibility is to capture whether or not the
 input was initially`disabled` and skip enabling such elements after the
 save completes.

 Alternatively, there could be a CSS solution where `pointer-events:none`
 or `cursor:progress` is added to the controls. Unfortunately there's no
 CSS property to make inputs inert yet.

 Yet more alternatively, a `fieldset` element actually can take a
 `disabled` attribute and it disables all inputs inside. So that's another
 option, where a new `fieldset` could be injected as a child of the
 existing `form` and the `disabled` property could be set to `true` during
 save. It's too bad that the `disabled` attribute itself.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32941#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list