[wp-trac] [WordPress Trac] #36528: Only run imagemin task inside precommit task if images are added/modified
WordPress Trac
noreply at wordpress.org
Thu Apr 14 23:14:46 UTC 2016
#36528: Only run imagemin task inside precommit task if images are added/modified
------------------------------+------------------
Reporter: iseulde | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.6
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
------------------------------+------------------
Comment (by iseulde):
You'll have exactly the same issue with e.g. the `postcss` task for CSS
files. I don't think the `precommit` task should look at that as you want
to make sure ''your'' changes are ready for commit or to be uploaded as a
patch, and not have all images modified because the module changed. This
should be a separate commit and is likely to be the task of someone else,
it needs its own ticket etc. At some point someone will run `prerelease`
which will make sure the changes are detected. We could even make sure all
tasks with `precommit` are run if there are no file modifications.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/36528#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list