[wp-trac] [WordPress Trac] #36528: Only run imagemin task inside precommit task if images are added/modified

WordPress Trac noreply at wordpress.org
Thu Apr 14 22:27:33 UTC 2016


#36528: Only run imagemin task inside precommit task if images are added/modified
------------------------------+------------------
 Reporter:  iseulde           |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  4.6
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+------------------

Comment (by netweb):

 I've two use cases where this will trip us up:

 1. When core updates `grunt-contrib-imagemin` without the files being
 modified they won't benefit from further enhancements of the module.

 2. This is similar to 1, though this time it is due to the nature of NPM's
 semantic versioning, `grunt-contrib-imagemin` uses `"imagemin": "^4.0.0",`
 hence any further major, minor, or patch level releases in the 4.x branch
 of Imagemin will be installed by any user who creates a fresh
 clone/checkout of the develop, or deletes the `node_modules` folder to run
 `npm install` again, or runs `npm update`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36528#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list