[wp-trac] [WordPress Trac] #26855: get_blogaddress_by_id used in wp-activate.php limits functionality in MU Domain Mapped Sites

[WordPress Trac]

#26855: get_blogaddress_by_id used in wp-activate.php limits functionality in MU
Domain Mapped Sites
----------------------------------------+------------------------
 Reporter:  boboudreau                  |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  4.6
Component:  Networks and Sites          |     Version:  3.0
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:  multisite
----------------------------------------+------------------------
Changes (by jeremyfelt):

 * keywords:  2nd-opinion has-patch => needs-patch good-first-bug
 * milestone:  Awaiting Review => 4.6


Comment:

 We've removed `get_blogaddress_by_id()` from almost everywhere else in
 core by now. After poking around a bit more, it seems like `get_home_url(
 $blog_id )` would work here.

 Replying to [comment:7 ArkonLabs]:
 > but aside from that, the Log In link at the bottom leads to the network
 site instead of the mapped domain. It doesn't even lead to the
 subdirectory URL, it simply leads to the network site url.

 This is likely happening for a different reason. If a `blog_id` is not
 passed in the request, or if the resulting domain is the same as the
 `network_home_url()`, then a link to the network login will be shown.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26855#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform