[wp-trac] [WordPress Trac] #35557: grunt precommit should run phpunit tests

[WordPress Trac]

#35557: grunt precommit should run phpunit tests
------------------------------+----------------------
 Reporter:  ericlewis         |       Owner:  ocean90
     Type:  task (blessed)    |      Status:  closed
 Priority:  normal            |   Milestone:  4.5
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+----------------------

Comment (by netweb):

 In [attachment:35557.6.diff] are two fixes/tweaks:

 * First fixes a mistake I made in my original patch which landed as part
 of r36906, for CSS files the `precommit` task should be calling the
 `precommit:css` task, and not `postcss:core` directly. FWIW the
 `postcss:core` task only calls `precommit:css` anyway, so its not broken
 per se, but it's not inline with the purpose of the original patch and
 should be fixed to operate in the same fashion as the other `precommit`
 sub tasks.

 * Secondly a tweak to the `prerelease` task introduced in r36930, the
 patch removes the task `build` from the `prerelease` task list as `build`
 was being ran twice causing the `prerelease` task to take much more time
 than it should. The `build` task is triggered as part of the
 `precommit:js` task which in turn calls the `qunit:compiled` task which
 includes the `build` task in its task list.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35557#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform