[wp-trac] [WordPress Trac] #29974: Focus handle at wrong place when you click reply

[WordPress Trac]

#29974: Focus handle at wrong place when you click reply
-------------------------------------+-------------------------------------
 Reporter:  nhuja                    |       Owner:  jorbin
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.4
Component:  Comments                 |     Version:  2.7
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch early has-     |     Focuses:  accessibility,
  screenshots needs-screenshots      |  javascript
-------------------------------------+-------------------------------------

Comment (by helen):

 Replying to [comment:47 greenshady]:
 > We need to learn from the mistakes of the past when such changes happen.
 I think this is clearly one of those times where we need to take a step
 back and realize that this is a breaking change for many users, even
 though it fixes a longstanding accessibility bug.

 There's a Make/Core post because we know it's a breaking change and needs
 feedback. I think what we're seeing today is that there are more
 committers and a number are more aggressive when it comes to what lands in
 trunk - not waiting for something to be perfect before trying it out.
 Realistically, the number of people who test things in patch form is tiny.
 Reverts are easy, and more feedback leads to better improvements. I think
 generally it also helps tickets keep moving instead of stagnating.

 > What I'd like to see is a parameter for `comment_form()` called
 `comment_field_position` (or something like that), which can default to
 the new position.

 That's the kind of thing that ends up as technical debt in the future, but
 it does seem like it will be necessary to either do something along those
 lines and/or provide very clear documentation on how to change it back. If
 what's there doesn't allow changing back via hooks, that should be looked
 at as well.

 > I'd also still like for the comment reply JS to focus on the first field
 in the form, regardless of what that field is.

 I didn't realize this didn't also go in :) We should do that, yes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29974#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform