[wp-trac] [WordPress Trac] #29974: Focus handle at wrong place when you click reply
WordPress Trac
noreply at wordpress.org
Mon Sep 28 22:22:00 UTC 2015
#29974: Focus handle at wrong place when you click reply
-------------------------------------+-------------------------------------
Reporter: nhuja | Owner: jorbin
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 4.4
Component: Comments | Version: 2.7
Severity: normal | Resolution:
Keywords: has-patch early has- | Focuses: accessibility,
screenshots needs-screenshots | javascript
-------------------------------------+-------------------------------------
Comment (by greenshady):
This is a continuation of the discussion on the Make post:
https://make.wordpress.org/core/2015/09/25/changes-to-fields-output-by-
comment_form-in-wordpress-4-4/comment-page-1/#comment-27867
We're talking about making a major front end visual change to millions of
sites (a welcome change for those of us who care about accessibility).
We're talking 10 years of history here. There needs to be the ability for
a plugin/theme author to hook in and revert the comment field position
change.
I could be wrong in assuming that the support forums will be filled with
angry users wondering why their comment forms changed suddenly. I could
be wrong in assuming that my theme forums will be filled with "WTF did you
do to my site" topics. I've been around too long to be that optimistic
though. We need to learn from the mistakes of the past when such changes
happen. I think this is clearly one of those times where we need to take
a step back and realize that this is a breaking change for many users,
even though it fixes a longstanding accessibility bug.
What I'd like to see is a parameter for `comment_form()` called
`comment_field_position` (or something like that), which can default to
the new position. That way, at least someone can create a plugin that
will revert it to the old position (I'll even volunteer to build the
plugin). That will mitigate some of the support tickets and keep us from
having to copy/paste the standard "this is a bug fix" reply.
I'd also still like for the comment reply JS to focus on the first field
in the form, regardless of what that field is. There are legitimate
reasons to have fields before the comment field (a star rating field
immediately comes to mind). Sure, a plugin dev could roll their own JS,
but core could just as easily simply focus on the first focus-able field.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/29974#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list