[wp-trac] [WordPress Trac] #34073: Comment walker calls get_comment_link with invalid arguments

WordPress Trac noreply at wordpress.org
Tue Sep 29 22:23:54 UTC 2015


#34073: Comment walker calls get_comment_link with invalid arguments
---------------------------+--------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.4
Component:  Comments       |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+--------------------
Changes (by peterwilsoncc):

 * keywords:  reporter-feedback =>


Comment:

 Replying to [comment:2 boonebgorges]:
 > It appears that the problem with `get_comment_link()` occurs only when a
 theme doesn't provide a comment-formatting 'callback' param, or when the
 callback explicitly passes `$args` to `get_comment_link()`. (I guess I'd
 been testing with default themes - like twentytwelve - that
 `get_comment_link()` without any parameters.) Can you share your setup
 when testing? What theme are you using?

 Of course:

 * trunk install using twenty fifteen
 * five comments per page
 * occurred in both first- and last page first modes
 * test post had twelve comments

 twenty fifteen displays comments with:

 {{{#!php
 wp_list_comments( array(
     'style'       => 'ol',
     'short_ping'  => true,
     'avatar_size' => 56,
 ) );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34073#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list