[wp-trac] [WordPress Trac] #34073: Comment walker calls get_comment_link with invalid arguments

[WordPress Trac]

#34073: Comment walker calls get_comment_link with invalid arguments
-------------------------------+--------------------
 Reporter:  peterwilsoncc      |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  4.4
Component:  Comments           |     Version:  trunk
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+--------------------
Changes (by boonebgorges):

 * keywords:   => reporter-feedback
 * milestone:  Awaiting Review => 4.4


Comment:

 See #8071. The way it used to work is that `comments_template()` would
 fetch *all* comments, and `Walker_Comment` would handle pagination.
 [34561] changed this behavior so that only the proper comments are fetched
 in the initial query. Then, to fool `Walker_Comment` into displaying all
 and only the comments we pass to it, we pass 'page=1'.

 It appears that the problem with `get_comment_link()` occurs only when a
 theme doesn't provide a comment-formatting 'callback' param, or when the
 callback explicitly passes `$args` to `get_comment_link()`. (I guess I'd
 been testing with default themes - like twentytwelve - that
 `get_comment_link()` without any parameters.) Can you share your setup
 when testing? What theme are you using?

 I'll need to do some more analysis, but it may be that in order to fix
 this, `get_comment_link()` will need to ignore some of the `$args` passed
 to it in at least some cases. Grumble grumble grumble.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34073#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform