[wp-trac] [WordPress Trac] #33587: Notification Functions Should be Replaced by Hooks

WordPress Trac noreply at wordpress.org
Wed Sep 16 21:59:18 UTC 2015


#33587: Notification Functions Should be Replaced by Hooks
-----------------------------------+------------------
 Reporter:  dshanske               |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  4.4
Component:  Mail                   |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------

Comment (by boonebgorges):

 In [changeset:"34250"]:
 {{{
 #!CommitTicketReference repository="" revision="34250"
 Don't notify post authors about spam comments.

 [34106] moved post author notification to a hook, and in the process,
 missed
 the 'spam' check. This changeset restores that check.

 To make unit testing easier, the notification callbacks have been
 refactored
 to return values: false when various conditions aren't met (eg, approved
 comments should not trigger moderation emails), and the return value of
 the
 `wp_notify_*()` function otherwise.

 Props cfinke, kraftbj.
 See #33587.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33587#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list