[wp-trac] [WordPress Trac] #33587: Notification Functions Should be Replaced by Hooks

[WordPress Trac]

#33587: Notification Functions Should be Replaced by Hooks
-----------------------------------+------------------
 Reporter:  dshanske               |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  4.4
Component:  Mail                   |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------

Comment (by boonebgorges):

 Replying to [comment:30 cfinke]:
 > r34106 introduced a bug causing email notifications to be sent for
 comments that have been caught as spam.
 >
 > Steps to reproduce (if you're running Akismet):
 >
 > 1. Ensure that you have checked the "Email me whenever [] anyone posts a
 comment" option in Settings > Discussion.
 > 2. Leave a comment on a post you wrote, and use the author name `viagra-
 test-123`. This will guarantee a spam result from Akismet.
 > 3. Check your WordPress Spam folder; the comment will be in there.
 > 4. Check your email; you should have a "New comment on your post" email
 from the comment you left in step 2.
 >
 > Patch forthcoming.  Patch and steps to reproduce generated in
 cooperation with @kraftbj.

 Thanks for the patch. I can confirm that this was missed in [34106]. It
 only applies to `wp_new_comment_notify_postauthor()`, because the
 moderator check was already doing a check for `'0'`, which is redundant
 with `!= 'spam'`.

 I'll try to write a unit test that reflects the problem.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33587#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform