[wp-trac] [WordPress Trac] #33361: "Edit Comment" metabox header styling is inconsistent with others

[WordPress Trac]

#33361: "Edit Comment" metabox header styling is inconsistent with others
--------------------------+------------------------------------------------
 Reporter:                |       Owner:  rachelbaker
  johnjamesjacoby         |      Status:  accepted
     Type:  defect (bug)  |   Milestone:  4.4
 Priority:  normal        |     Version:
Component:  Comments      |  Resolution:
 Severity:  minor         |     Focuses:  ui, accessibility, administration
 Keywords:  has-patch     |
--------------------------+------------------------------------------------

Comment (by johnjamesjacoby):

 Hi everyone. Thanks for the attention, and thanks @afercia for the in-
 depth refresher.

 I think that, so far, all of us involved in this ticket are really
 narrowing in on our specialties instead of identifying (hence agreeing)
 that there is actually something wrong with the markup or styling of this
 specific page. If y'all feel there isn't anything wrong, then I'd vote we
 close this ticket and move on. I don't think this is the case, though, and
 I think we've lost sight of the problem by choosing to focus on how poor
 my solution apparently was instead of iterating and suggesting more
 acceptable improvements.

 It may make sense to re-outline the details, so we can work towards and
 propose agreeable solutions. Here's my take:

 * Visually, the elements used to represent header text in `comments.php`
 are not in alignment with the rest of `wp-admin`
 * Mark-up wise, the elements used to represent header text in
 `comments.php` are out-of-date with current trends in `wp-admin` standards
 * Accessibility wise, the structure on this page is unique compared to
 other similar metabox insides
 * CSS wise, styling is being applied in unintended ways because of the
 aforementioned legacy out-of-date mark-up

 A few other tidbits:

 * My (vetoed) suggestion of adding the `screen-reader-text` class to the
 `legend` tag is not unheard of. It's used no less than 40 times in `wp-
 admin` already for settings (though not paired with header tags, they are
 paired with `th`'s)
 * The `link_target_meta_box()` function is where I got this idea from,
 meaning we should include whatever conclusions we come to here, there
 also, since it's already in core with all the bad qualities noted above.
 * Whether or not these should be collapsable metaboxes is mostly
 irrelevant to the interests of the visual inconsistency I've identified.
 They could be, and maybe they should be, but they aren't and never have
 been and no one seems to have complained but me until now. :)

 @afercia - have you applied either of my attached patches to assess the
 assumed negative impact of them? Can you explain a bit about why this does
 not negatively impact other hidden fieldset legends in the same way, or
 why those are acceptable and this is not?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33361#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform