[wp-trac] [WordPress Trac] #28344: Remove "Week Starts On" setting UI
WordPress Trac
noreply at wordpress.org
Wed Sep 2 08:04:39 UTC 2015
#28344: Remove "Week Starts On" setting UI
--------------------------------+---------------------------------
Reporter: markjaquith | Owner:
Type: enhancement | Status: new
Priority: low | Milestone: 4.4
Component: Options, Meta APIs | Version:
Severity: minor | Resolution:
Keywords: has-patch | Focuses: ui, administration
--------------------------------+---------------------------------
Comment (by swissspidy):
Replying to [comment:22 stephenharris]:
> @swissspidy I think your latest patch only does the first point(?).
It did, I just linked to the wrong attachment. My bad!
> In any case, if this UI option is to be hidden could we provide a filter
for plugin developers to 'unhide' it if they deem it relevant to their
plugin, as suggested by Helen?
> On another note I personally don't see the advantage in checking if the
option is at its default value. Anyone who has a fresh install wont see
the option to change it, and those who have already changed that setting
from the default are less likely to need to change it again, but they are
the only ones who will be able to see it. You also have a confusing UX of
changing at setting and it disappearing.
>
> It would be better to simply hide the setting and add a filter to unhide
it.
You're right, this could be very confusing. [attachment:28344.3.patch
28344.3.patch] introduces a new `show_start_of_week_setting` filter which
defaults to `false`. That would hide the option for everyone and give
plugin authors the ability to bring it back.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28344#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list