[wp-trac] [WordPress Trac] #34527: WP oEmbed: Improve height attribute sanitization (was: WP oEmbed: the iframe height attribute doesn't need "px")

WordPress Trac noreply at wordpress.org
Sat Oct 31 19:59:22 UTC 2015


#34527: WP oEmbed: Improve height attribute sanitization
----------------------------------------------+----------------------------
 Reporter:  afercia                           |       Owner:
     Type:  defect (bug)                      |      Status:  new
 Priority:  normal                            |   Milestone:  4.4
Component:  Embeds                            |     Version:  trunk
 Severity:  normal                            |  Resolution:
 Keywords:  has-screenshots has-patch commit  |     Focuses:  ui,
                                              |  javascript
----------------------------------------------+----------------------------
Changes (by swissspidy):

 * keywords:  has-screenshots has-patch => has-screenshots has-patch commit


Comment:

 [attachment:34527.3.patch] is a simpler version of the second patch. The
 ~~ double NOT bitwise operator turns `NaN` into `0`, removing the need for
 an `isNaN` check.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34527#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list